Skip to content

NETOBSERV-1101: Hide service TLS config#1302

Open
jotak wants to merge 1 commit intonetobserv:mainfrom
jotak:hide-service-tls
Open

NETOBSERV-1101: Hide service TLS config#1302
jotak wants to merge 1 commit intonetobserv:mainfrom
jotak:hide-service-tls

Conversation

@jotak
Copy link
Member

@jotak jotak commented Feb 23, 2026

Description

Dependencies

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oliviercazade for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak changed the title Hide service TLS config (upstream feature) NETOBSERV-110: Hide service TLS config (upstream feature) Mar 2, 2026
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 2, 2026 •
edited by openshift-ci bot
Loading

@jotak: This pull request references NETOBSERV-110 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Dependencies

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak jotak changed the title NETOBSERV-110: Hide service TLS config (upstream feature) NETOBSERV-110: Hide service TLS config Mar 2, 2026
@jotak jotak mentioned this pull request Mar 2, 2026
Merged
10 tasks
@jotak jotak changed the title NETOBSERV-110: Hide service TLS config NETOBSERV-1101: Hide service TLS config Mar 3, 2026
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Mar 3, 2026 •
edited by openshift-ci bot
Loading

@jotak: This pull request references NETOBSERV-1101 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Dependencies

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak jotak force-pushed the hide-service-tls branch from 4d8b291 to c85b528 Compare March 3, 2026 15:32
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

New image:

quay.io/netobserv/network-observability-console-plugin:f9fc0d5

It will expire in two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=f9fc0d5 make set-plugin-image

@openshift-ci
Copy link

openshift-ci bot commented Mar 3, 2026 •
edited
Loading

@jotak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/plugin-cypress c85b528 link true /test plugin-cypress
ci/prow/images c85b528 link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jotak jotak added the needs-review Tells that the PR needs a review label Mar 16, 2026
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.89%. Comparing base (b9330e3) to head (c85b528).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   50.89%   50.89%           
=======================================
  Files         222      222           
  Lines       12007    12007           
  Branches     1520     1520           
=======================================
  Hits         6111     6111           
  Misses       5319     5319           
  Partials      577      577
Flag Coverage Δ
uitests 54.36% <ø> (ø)
unittests 41.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leandroberetta leandroberetta Awaiting requested review from leandroberetta

@OlivierCazade OlivierCazade Awaiting requested review from OlivierCazade

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

jira/valid-reference needs-review Tells that the PR needs a review ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jotak @openshift-ci-robot